I contributed to Firefox. The Mozilla guys are awesome. But if you are used to G...

indygreg2 · on April 2, 2015

We know. One of those things that was established 10+ years ago and has a lot of built-up inertia keeping it going.

It's part of my job role at Mozilla to bring this process into modernity. We're getting there. Slowly. GitHub pull requests will be supported in some form. Hopefully by July.

jordigh · on April 1, 2015

Ignore anything about MQ. They have old docs on using MQ that we've been trying to wean them away from.

Modern hg is far better than MQ, and in some situations, better than git. You can edit, you can rebase, you can amend, you can evolve.

k__ · on April 1, 2015

jordigh · on April 1, 2015

Mercurial queues. I thought that's what you meant with "patches".

k__ · on April 1, 2015

Ah yes. MQ was the plugin used to create those patches, now I remember.

They stopped using? Even on the main Firefox repo?

jordigh · on April 1, 2015

Like git, Linux, Mercurial, and gcc development, they have a patch-based code review flow, but MQ is not needed to produce the patches that they expect. You can do the same without MQ, and they will never know the difference on their end.

I actually rather like email-based code review. It's really easy to keep editing and rebasing your patch while people comment on it. If Mercurial Evolve picks up, this will be an awesome new way to work, especially if Kallithea or Bitbucket grows the features to support it.

However, current Mozilla development, AIUI, is moving towards ReviewBoard, although I have heard a growing mutinous group in Mozilla who just wants to chuck all homegrown solutions and slap all of their code on github like everyone else.