I feel he was right to disclose the illegal collection of phone records. However, he was wrong to disclose pretty much everything else that he did. He disclosed details of activities that weren't illegal and has hurt the NSAs ability to do its job on behalf of the United States.
I disagree (mildly) with his first point that operationally the US is affected. Because it's been a long held assumption that the US had extensive spying programs in place. Snowden simply provided the evidence. So, if you had something to hide from the NSA you were already hiding it as best as you could. Maybe, now a few more attack vectors have been revealed and hiding/encryption practices will be updated.
