Hacker News new | past | comments | ask | show | jobs | submit login

Not sure if you're serious. I can't remember working for any company that took more than a day to review a PR. I think this company took about 1 day to provide QA feedback and I was thinking that it's so slow.

In startup land, I got my code reviewed by the CTO within a few hours. It was rare if it required a whole day like if he was too busy.

In my current company, the other dev usually reviews and merges my code to staging within an hour. Crazy thing is we don't even write tests. A large project with no tests.




In my current job I did a PR in the first week of joining. It was reviewed after exactly 2 years. I had to rewrite the whole PR because of the affected lines had changed. Of course I did not remember at all what is was about.

Some PRs are faster but some are slower as well.


Maybe you meant getting a PR merged. Then 3 days seems possible depending on the approach. At my current company, the team is small so approval process is quite fast and not too fussy.


Why would I write "reviewed" when I mean "merged"? I meant reviewed.


I was definitely serious.




Join us for AI Startup School this June 16-17 in San Francisco!

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: