Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

| distinct lack of focus on code reviews as part of the assessment

"Writing code is easy, reading code is hard"

An interview based on reading, explaining and critiquing complicated code would give a better window into a candidate's skills than having them solve the kind of coding challenge that can be completed in a short interview.

Also, being able to identify which algorithms would be useful in solving a unique problem and explain what the pros & cons are would go further than implementing an algorithm abstractly.



It’s my personal interview approach, I have a some 60 lines of code example I will ask questions about. What does it do, if I wanted to change x, where would I need to do this, etc. Seniors will take 30 seconds for the first two questions. I‘ve had junior applicants where I had to stop after 15 minutes of trying.


I think this format is very conducive to leveling because there are some tells that are really obvious. Like input validation, error handling, database indices, database column types, race conditions, etc. You can't fake these easily, but with experience, they surface quickly.


That was my favorite interview ever.

The guy gave me 30 lines of code, and asked questions about it. Including finding the questionable constructs in it.


It was also my favorite interview format as well.

Interviewer had a small API. Found missing error handling, missing validations, poor choice of ID column type, missing index for a high volume read query, possible XSS vector.

Loved the format so much I ended up making a small FOSS tool for code review as interview: https://coderev.app


This looks great, I might use it next time I'm interviewing.


I tried this and found that there are a set of potentially good candidates who simply cannot bring themselves to criticize anything in front of an interviewer due to the power dynamics of the interviewer/interviewee relationship.


Those are the same people who will know the project is heading off a cliff and not tell you before it is too late.


You have to set them up for it.

    "Imagine that this code was written by a junior dev; review it and tell me how it can be improved, where the problems are, and other feedback".
Or

    "We just hired a new intern and he pushed this PR.  I need you to help me review this code for issues and make sure it's production ready".


i would argue that isn’t a good trait in an employee either




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: