Hacker News new | past | comments | ask | show | jobs | submit login

It depends on many factors. No policy fits every team or situation. If feedback times - weather due to pipeline or personal/reviews - are long, I would also push larger PRs. Also reviews rarely really improve anything besides bikeshedding stuff like style or whatever the reviewer might find more pleasant in terms of overall structure. If reviews were done right you’d have to deep dive into the problem the requester tried to solve and understand his concepts and ideas of the solution. To do so, I do important reviews (which are super rare) in pair programming style with the requester. I suggest you should do the same especially if lot of code is changed or added. I assume you have proper testing in place. Looking at tests can help a lot to understand production code



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: