I like both of those a lot but I'm all about the Berkeley Mono which I picked up after it appeared on HN. It feels like a modern version of an ancient old terminal font. https://berkeleygraphics.com/typefaces/berkeley-mono/
Note they have different versions of the zero to cater to different tastes. The dot, the slash, the negative slash and the just figure it out it's slightly less round than a capital O are all available. They also have a ligatured version for people who are into that.
- fira code: https://github.com/tonsky/FiraCode
- jetbrains mono: https://www.jetbrains.com/lp/mono/
And I have tried a lot. Everything else feels weirdly stretched or cramped or not legible enough etc.