We did this in Indiana and handled this by having an income cap for voucher eligibility. The reality is that people living in poor areas now have access to better schools. Rich people don't get vouchers.
The means test was added to Indiana's voucher program to get it passed, and it was a good thing. I put a lot of time in doing grass-roots work to get it passed, and honestly it has been great for kids, teachers (unions are good, but having employers compete for you is even better)... the only people it's been bad for are professional public school administrators and construction companies that sell school districts new buildings instead of paying teachers more.
I’m with you on this generally, and I’m glad Indiana included a means test. But I’m not sold that a shift to voucher systems more broadly will include means tests.