Yes, but a lot of people prefer to have every commit in master in a buildable st... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

		lf-non on Dec 12, 2021 \| parent \| context \| favorite \| on: We check our node_modules folder into source contr... Yes, but a lot of people prefer to have every commit in master in a buildable state. Otherwise things like git bisect become a lot more tedious.

xboxnolifes on Dec 12, 2021 | [–]

> have every commit in master

Yes, but a PR commit is not in master.

pjerem on Dec 12, 2021 | | [–]

I see you, little squasher :)

ng12 on Dec 12, 2021 | | | [–]

But then you lose the benefit. Hiding node_modules during code review is the easy part.

clintonb on Dec 12, 2021 | [–]

Some teams force all pull requests to be squashed to a single commit.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact