Commits should be as small as possible, but not break anything.

With git the more important questions: When do you push?

Not as often as possible. I repeatedly regret a push, because i need to commit a revert/change commit afterwards. If i had waited, this could have been cleaned up before pushing.