NYC was quite affordable when nobody wanted to live there (like the 1970's). Once the city was 'cleaned up', demand for housing has increased and, as much as people bemoan all of the construction, housing units haven't matched pace.

The result has been predictable and inevitable when supply is growing slowly and demand is growing rapidly: increased prices.